> On Sept. 21, 2018, 9:41 a.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 244-245 (patched) > > <https://reviews.apache.org/r/68758/diff/4/?file=2090405#file2090405line244> > > > > An alternative to the closure we sometimes use in tests is to rely on > > `get` performing the hard check, but this is just as fine.
Yeah I know but it seems safer to me to use `ASSERT_*` so (I thought) the test teardown will be performed. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208843 ----------------------------------------------------------- On Sept. 20, 2018, 3:45 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68758/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 3:45 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > Added unit tests for adding/updating invalid resource provider configs. > > > Diffs > ----- > > src/tests/agent_resource_provider_config_api_tests.cpp > e6a68bae1a9e3e773ea45deae4951664ab81a857 > > > Diff: https://reviews.apache.org/r/68758/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
