> On Sept. 21, 2018, 9:41 a.m., Benjamin Bannier wrote:
> > src/tests/agent_resource_provider_config_api_tests.cpp
> > Lines 240 (patched)
> > <https://reviews.apache.org/r/68758/diff/4/?file=2090405#file2090405line240>
> >
> > Ups, that turned out to be a lot. Thanks for doing this.
The previous way (`fs::list`) relies on the fact that `*` won't match dotfiles
so it seems the current way is more robust. Also currently we rely on
`fs::list("path/*/*")` to implement `slave::paths::getResourceProvider*Paths`,
which won't be portable on Windows as only the filename part can have wildcards.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68758/#review208843
-----------------------------------------------------------
On Sept. 20, 2018, 3:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68758/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2018, 3:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests for adding/updating invalid resource provider configs.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp
> e6a68bae1a9e3e773ea45deae4951664ab81a857
>
>
> Diff: https://reviews.apache.org/r/68758/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
