> On Sept. 19, 2018, 3:35 p.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.cpp > > Lines 310-314 (patched) > > <https://reviews.apache.org/r/68763/diff/1/?file=2090244#file2090244line312> > > > > This is a pretty bare-bones API. I believe if we'd instead schedule > > removal once the launch has finished, we'd not only remove the burden to > > retry from the caller, but probably also make this function safer to use. > > > > This would likely require us to maintain > > `Promise<Owned<LocalResourceProvider>>` instead. > > > > We should probably move this into below `then` continuation.
Dropping this since this no longer fits the current solution. > On Sept. 19, 2018, 3:35 p.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.cpp > > Line 290 (original), 319 (patched) > > <https://reviews.apache.org/r/68763/diff/1/?file=2090244#file2090244line321> > > > > Not sure how this will look like once we handle agent failover, but it > > seems this removal should only happen after successful `stop`. That way we > > might e.g., be able to maintain consistent state (config exists <==> > > container running). I'm now aiming for a temporarily fix. We should have a more thorough thinking around the lifecycle management of the standalone containers. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208767 ----------------------------------------------------------- On Sept. 19, 2018, 5:14 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68763/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 5:14 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > This patch introduces a `LocalResourceProvider::stop` function to > perform RP-specific stop procedures. SLRP uses this function to kill > plugin container before its config is removed. > > > Diffs > ----- > > src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55 > src/resource_provider/local.hpp 20bcc78d3fe847e03526fa59116bdbac92ec1e29 > src/resource_provider/storage/provider.hpp > 5a371b19289c6e39fedd4cda65fa8be432d095e6 > src/resource_provider/storage/provider.cpp > 6475f653263337c381b6080695d09c49e5ea8fcf > > > Diff: https://reviews.apache.org/r/68763/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
