> On Sept. 19, 2018, 5:35 p.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.cpp > > Line 290 (original), 319 (patched) > > <https://reviews.apache.org/r/68763/diff/1/?file=2090244#file2090244line321> > > > > Not sure how this will look like once we handle agent failover, but it > > seems this removal should only happen after successful `stop`. That way we > > might e.g., be able to maintain consistent state (config exists <==> > > container running). > > Chun-Hung Hsiao wrote: > I'm now aiming for a temporarily fix. We should have a more thorough > thinking around the lifecycle management of the standalone containers.
I am still in favor of only removing the config after "successful" cleanup. That way we have a shot at having consistent state after failover which can be fixed by users with the expected API (`remove_resource_provider_config`). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208767 ----------------------------------------------------------- On Sept. 21, 2018, 1:21 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68763/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 1:21 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > When processing `REMOVE_RESOURCE_PROVIDER_CONFIG`, the local resource > provider daemon now performs a best-effort cleanup by killing all > standalone containers prefixed by the 'cid_prefix' of the resource > provider. During the cleanup, no resource provider config with the same > type and name can be added. > > > Diffs > ----- > > src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55 > > > Diff: https://reviews.apache.org/r/68763/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
