> On Sept. 21, 2018, 10:50 a.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.cpp > > Lines 431-433 (original), 483-485 (patched) > > <https://reviews.apache.org/r/68763/diff/2/?file=2090658#file2090658line488> > > > > How does this hold? It seems we should e.g., insert a `remove` call > > before continuing with `_launch`. > > Chun-Hung Hsiao wrote: > I assume you're talking about an `erase`. No we cannot simply erase it, > because the `providers` struct is the source of truth whether we should > accept or reject an add, an update, or a remove when requesting the auth > token.
Oh now I get it. You're suggesting that we should explicitly call a `remove`? But in the case of `update`, we don't need to actually do the cleanup as we do in `remove`. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208846 ----------------------------------------------------------- On Sept. 20, 2018, 11:21 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68763/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 11:21 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > When processing `REMOVE_RESOURCE_PROVIDER_CONFIG`, the local resource > provider daemon now performs a best-effort cleanup by killing all > standalone containers prefixed by the 'cid_prefix' of the resource > provider. During the cleanup, no resource provider config with the same > type and name can be added. > > > Diffs > ----- > > src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55 > > > Diff: https://reviews.apache.org/r/68763/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
