> On Sept. 26, 2018, 11:16 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 609-610 (original), 627-628 (patched) > > <https://reviews.apache.org/r/68401/diff/5-6/?file=2090625#file2090625line631> > > > > This message can be displayed by the scheduler (e.g. Aurora) to its > > users. They will ask which quota this is. It might be worth adding some > > indication if this was a persistent volume quota.
I added the persistent volume ID to the message. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review209057 ----------------------------------------------------------- On Sept. 24, 2018, 4:58 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68401/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 4:58 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Added persistent volume support to the `disk/xfs` isolator. This > implementation largely tracks the `disk/du` implementation in that > we now keep a map of paths in each container info structure. We now > defer quota clean up to project ID reclaimation time so that we can > use the same mechanism for sandbox and persistent volume paths. > > We explicitly exclude mount disks from XFS project quotas, but we still > track them so that we can correctly publish their usage information in > the container `DiskStatistics` message. This means that mount disks are > not required to be XFS filesystems or have project quotas configured. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 38c467b47cb7c04803b0709b8239458fb26abb61 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 783da0407528c044035d18cc59a744353921d64c > src/tests/containerizer/xfs_quota_tests.cpp > 2b3a2e25f5075357f090d47826698e7bb6fdf969 > > > Diff: https://reviews.apache.org/r/68401/diff/6/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
