----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review209885 -----------------------------------------------------------
src/linux/seccomp/seccomp.cpp Lines 21 (patched) <https://reviews.apache.org/r/68018/#comment294508> We avoid `using namespace foo` statements as it is not explicit about which symbols are pulled in, and it can often pull in a lot of symbols, which sometimes lead to conflicts. src/linux/seccomp/seccomp.cpp Lines 80 (patched) <https://reviews.apache.org/r/68018/#comment294507> `static const` src/linux/seccomp/seccomp.cpp Lines 99 (patched) <https://reviews.apache.org/r/68018/#comment294506> `static const` src/linux/seccomp/seccomp.cpp Lines 135 (patched) <https://reviews.apache.org/r/68018/#comment294509> Drop the fullstop at the end, otherwise this error will stringify as: ``` Failed to load Seccomp filter.: invalid argument ``` - James Peach On Aug. 6, 2018, 1:38 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68018/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 1:38 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9034 > https://issues.apache.org/jira/browse/MESOS-9034 > > > Repository: mesos > > > Description > ------- > > `SeccompFilter` class is a wrapper for `libseccomp` API. Its main > purpose is to provide a translation of the `ContainerSeccompProfile` > message into calls of `libseccomp` API. > > > Diffs > ----- > > src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 > src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 > src/linux/seccomp/seccomp.hpp PRE-CREATION > src/linux/seccomp/seccomp.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68018/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
