> On Dec. 26, 2018, 7:40 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 73 (patched) > > <https://reviews.apache.org/r/68018/diff/8/?file=2114548#file2114548line73> > > > > Should `int arch` be `ContainerSeccompProfile::Architecture arch`?
The return type of `architectures()` is `const ::google::protobuf::RepeatedField<int>&`. > On Dec. 26, 2018, 7:40 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 125 (patched) > > <https://reviews.apache.org/r/68018/diff/8/?file=2114548#file2114548line125> > > > > Just a question: So we will only add a rule if the process's > > capabilities has **all** the `includesCaps` or has **any** of the > > `excludesCaps`, right? Updated the comments. > On Dec. 26, 2018, 7:40 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 166 (patched) > > <https://reviews.apache.org/r/68018/diff/8/?file=2114548#file2114548line166> > > > > Better to initilize `ret` with 0 rather than -1. I've just removed this line. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review211533 ----------------------------------------------------------- On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68018/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 3:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9034 > https://issues.apache.org/jira/browse/MESOS-9034 > > > Repository: mesos > > > Description > ------- > > `SeccompFilter` class is a wrapper for `libseccomp` API. Its main > purpose is to provide a translation of the `ContainerSeccompProfile` > message into calls of `libseccomp` API. > > > Diffs > ----- > > src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 > src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa > src/linux/seccomp/seccomp.hpp PRE-CREATION > src/linux/seccomp/seccomp.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68018/diff/11/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
