----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210022 -----------------------------------------------------------
src/tests/fetcher_tests.cpp Lines 98-109 (patched) <https://reviews.apache.org/r/69146/#comment294657> We can avoid duplication here by making `FetcherTest` a `MesosTest` (that one would already today take care of `launcher_dir` and `fetcher_cache_dir`). This function would than at most need to invoke `MesosTest::CreateSlaveFlags` and make its non-general additions. It probably even make sense to set `frameworks_home` in `CreateSlaveFlags` as well. That would remove the need for this function completely. - Benjamin Bannier On Oct. 25, 2018, 1:12 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69146/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 1:12 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gilbert Song, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Fetcher tests currently rely on some hard-coded paths, > for example, `/tmp/mesos/fetcher` and `/tmp/frameworks`. > Thus fetcher tests could fail if these directories already > exit. This patch adds a helper function `createSlaveFlags()` > to make use of the test sandboxes. The above paths will be > replaced by `fetch/` and `frameworks/` under the sandbox. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 283238cdda17a94e034baa195bd9d4b57e363b8a > > > Diff: https://reviews.apache.org/r/69146/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
