> On Oct. 24, 2018, 11:54 p.m., Benjamin Bannier wrote: > > src/tests/fetcher_tests.cpp > > Lines 98-109 (patched) > > <https://reviews.apache.org/r/69146/diff/2/?file=2102314#file2102314line98> > > > > We can avoid duplication here by making `FetcherTest` a `MesosTest` > > (that one would already today take care of `launcher_dir` and > > `fetcher_cache_dir`). This function would than at most need to invoke > > `MesosTest::CreateSlaveFlags` and make its non-general additions. > > > > It probably even make sense to set `frameworks_home` in > > `CreateSlaveFlags` as well. That would remove the need for this function > > completely.
Sounds good. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210022 ----------------------------------------------------------- On Oct. 25, 2018, 12:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69146/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 12:34 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gilbert Song, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Fetcher tests currently rely on some hard-coded paths, > for example, `/tmp/mesos/fetcher` and `/tmp/frameworks`. > Thus fetcher tests could fail if these directories already > exit. This patch makes `FetcherTest` a subclass of > `MesosTest` which has a `createSlaveFlags()` helper to > utilize the test sandboxes for related directories to > avoid interference. The above paths will be > replaced by `fetch/` and `frameworks/` under the sandbox. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 283238cdda17a94e034baa195bd9d4b57e363b8a > src/tests/mesos.cpp c0ab2f7d86c4059f08e730d29456e6cc84c85995 > > > Diff: https://reviews.apache.org/r/69146/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
