----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/#review210600 -----------------------------------------------------------
This patch fails to compile without r/69363, could you move the needed changes from there into this patch? src/csi/state.proto Lines 46 (patched) <https://reviews.apache.org/r/69362/#comment295321> Let's describe the semantics around empty vs. populated `parameters` maps instead of introducing `OPTIONAL` here (which doesn't fit and is confusing). src/resource_provider/storage/provider.cpp Lines 2813 (patched) <https://reviews.apache.org/r/69362/#comment295323> Can we add a comment here mentioning what is supported? src/resource_provider/storage/provider.cpp Lines 2813 (patched) <https://reviews.apache.org/r/69362/#comment295324> Can we add a comment here mentioning what is valid? src/resource_provider/storage/provider.cpp Line 2821 (original) <https://reviews.apache.org/r/69362/#comment295322> Keep this? - Benjamin Bannier On Nov. 19, 2018, 10:29 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69362/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2018, 10:29 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > The parameters of CSI volumes created by SLRPs are now checkpointed, and > used to validate volumes created from previous SLRP runs. > > > Diffs > ----- > > src/csi/state.proto 8445399ac17cfef740c2523172b34fd5439f2d3a > src/resource_provider/storage/provider.cpp > c137fa4f13edc58d93c03a9dd32fdf9d38b38316 > > > Diff: https://reviews.apache.org/r/69362/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
