----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69599/ -----------------------------------------------------------
(Updated Jan. 5, 2019, 3:28 p.m.) Review request for mesos and Benjamin Mahler. Summary (updated) ----------------- Pulled up the resource quantities class for more general use. Repository: mesos Description ------- There are many places that we need to express the concept of resource quantities such as enforcing allocation quantities in the allocator and set guaranteed resource quantities with quota. However, the current code usually uses the complex Resources class which is unnecessary and inefficient. This patch pulls class ScalarResourceQuantities in sorter.hpp up, aiming to use it for all resource quantity related usages. We mostly preserve the map interface and added other utilities such as parsing. Diffs (updated) ----- src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa src/common/resource_quantities.hpp PRE-CREATION src/common/resource_quantities.cpp PRE-CREATION src/master/allocator/sorter/drf/sorter.hpp 084df82baef91eca5775b0bd17d943f3fb8df70b src/master/allocator/sorter/drf/sorter.cpp a648fac7e922ab0aefdf9363624d7242f1fc6588 src/master/allocator/sorter/random/sorter.hpp 800b22c67126c2b14c5259d9d122d2e196cc80d8 src/master/allocator/sorter/sorter.hpp 68cf6988ef1a156cf16951e3164261234e9abeeb Diff: https://reviews.apache.org/r/69599/diff/4/ Changes: https://reviews.apache.org/r/69599/diff/3-4/ Testing ------- make check Dedicated test in r/69600 Thanks, Meng Zhu
