> On Jan. 7, 2019, 5:14 a.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Line 671 (original), 671 (patched) > > <https://reviews.apache.org/r/69599/diff/4/?file=2117856#file2117856line671> > > > > Why do you say to consider this, we actually don't do anything to > > ensure this AFAIK, so it would fail, no? > > Meng Zhu wrote: > This denotes total resources in the cluster, conceptually should never be > negative? I glanced the code, this invariant seems to hold (make check also > passes). But I removed it. Let's revisit it later.
> conceptually should never be negative? Whoops, I initially read the check to be > 0 (and that's what my comment was referring to: 0 seems to be possible). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69599/#review211714 ----------------------------------------------------------- On Jan. 7, 2019, 6:23 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69599/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2019, 6:23 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > There are many places that we need to express the concept of > resource quantities such as enforcing allocation quantities > in the allocator and set guaranteed resource quantities with quota. > However, the current code usually uses the complex Resources > class which is unnecessary and inefficient. > > This patch pulls class ScalarResourceQuantities in sorter.hpp > up, aiming to use it for all resource quantity related usages. > We mostly preserve the map interface and added other utilities such > as parsing. > > > Diffs > ----- > > src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 > src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa > src/common/resource_quantities.hpp PRE-CREATION > src/common/resource_quantities.cpp PRE-CREATION > src/master/allocator/sorter/drf/sorter.hpp > 084df82baef91eca5775b0bd17d943f3fb8df70b > src/master/allocator/sorter/drf/sorter.cpp > a648fac7e922ab0aefdf9363624d7242f1fc6588 > src/master/allocator/sorter/random/sorter.hpp > 800b22c67126c2b14c5259d9d122d2e196cc80d8 > src/master/allocator/sorter/sorter.hpp > 68cf6988ef1a156cf16951e3164261234e9abeeb > > > Diff: https://reviews.apache.org/r/69599/diff/5/ > > > Testing > ------- > > make check > Dedicated test in r/69600 > > > Thanks, > > Meng Zhu > >
