----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review211996 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 10617 (patched) <https://reviews.apache.org/r/69158/#comment297583> We could rename it to `updateSlaveMessage` and reuse it below. src/tests/slave_tests.cpp Lines 10625-10626 (patched) <https://reviews.apache.org/r/69158/#comment297585> ``` Owned<MasterDetector> detector = master.get()->createDetector(); Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), slavFlags); ``` src/tests/slave_tests.cpp Lines 10633 (patched) <https://reviews.apache.org/r/69158/#comment297586> `org.apache.mesos.rp.test`, or maybe `org.apache.mesos.rp.mock`, for consistency. src/tests/slave_tests.cpp Lines 10652 (patched) <https://reviews.apache.org/r/69158/#comment297582> `std::move(endpointDetector)` - Chun-Hung Hsiao On Oct. 25, 2018, 10:47 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69158/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 10:47 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > Added an integration test for resource provider removal. > > > Diffs > ----- > > src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 > > > Diff: https://reviews.apache.org/r/69158/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
