> On Jan. 15, 2019, 6:58 a.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Lines 10625-10626 (patched) > > <https://reviews.apache.org/r/69158/diff/4/?file=2111265#file2111265line10625> > > > > ``` > > Owned<MasterDetector> detector = master.get()->createDetector(); > > Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), > > slavFlags); > > ```
Could you explain the pattern we follow? I mostly went for a `StandaloneMasterDetector` instead of an `Owned<MasterDetector>` because of the conceptually simpler type (value vs pointer), but we seem to use both here. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review211996 ----------------------------------------------------------- On Jan. 15, 2019, 4:03 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69158/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2019, 4:03 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > Added an integration test for resource provider removal. > > > Diffs > ----- > > src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 > > > Diff: https://reviews.apache.org/r/69158/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
