----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211942 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/seccomp/seccomp.proto Lines 22-23 (patched) <https://reviews.apache.org/r/68017/#comment297504> Here we just need one blank line rather than two. include/mesos/seccomp/seccomp.proto Lines 79 (patched) <https://reviews.apache.org/r/68017/#comment297529> So the value must be numeric? Do we support other types (like string value)? - Qian Zhang On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 11:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d > include/mesos/seccomp/seccomp.hpp PRE-CREATION > include/mesos/seccomp/seccomp.proto PRE-CREATION > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb > src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf > src/Makefile.am 188a47017221a931d8b965a4af5e033b77e6ce4e > > > Diff: https://reviews.apache.org/r/68017/diff/14/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
