> On Jan. 15, 2019, 8:41 a.m., Qian Zhang wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 79 (patched) > > <https://reviews.apache.org/r/68017/diff/14/?file=2118635#file2118635line79> > > > > So the value must be numeric? Do we support other types (like string > > value)?
> So the value must be numeric? Yes. > Do we support other types (like string value)? No. https://github.com/moby/moby/blob/8e610b2b55bfd1bfa9436ab110d311f5e8a74dcb/api/types/seccomp.go#L73 - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211942 ----------------------------------------------------------- On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 3:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d > include/mesos/seccomp/seccomp.hpp PRE-CREATION > include/mesos/seccomp/seccomp.proto PRE-CREATION > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb > src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf > src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 > > > Diff: https://reviews.apache.org/r/68017/diff/15/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
