> On Jan. 14, 2019, 3:38 p.m., Gilbert Song wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 21-28 (patched) > > <https://reviews.apache.org/r/68017/diff/14/?file=2118635#file2118635line21> > > > > This is my fault. Sorry, Andrei! > > > > Would you mind moving this .proto to /src/seccomp again? The previous > > suggestion was not appropriate after the second thought because: > > > > proto files under /include: > > They are public protobuf files that may be used by external/3th party > > modules, while some of the proto files like v1/v2.proto and fetcher.proto > > should be moved out from /include dir. this is a tech debt. > > > > proto files under /src: > > used for internal conversion. > > Andrei Budnik wrote: > I can't move it to `src/seccomp`, because `message ContainerLaunchInfo` > (from `include/mesos/slave/containerizer.proto`) depends on it!
Dropped. Forgot ContainerLaunchInfo is also a public facing protobuf (isolator module uses it). so /include should be good place to locate then. Thanks! - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211972 ----------------------------------------------------------- On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 7:24 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d > include/mesos/seccomp/seccomp.hpp PRE-CREATION > include/mesos/seccomp/seccomp.proto PRE-CREATION > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb > src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf > src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 > > > Diff: https://reviews.apache.org/r/68017/diff/15/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
