> On Jan. 15, 2019, 6:53 a.m., Chun-Hung Hsiao wrote: > > src/tests/api_tests.cpp > > Lines 7857 (patched) > > <https://reviews.apache.org/r/68147/diff/12/?file=2111264#file2111264line7857> > > > > ``` > > Owned<MasterDetector> detector = master.get()->createDetector(); > > ``` > > And > > ``` > > Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), > > slavFlags); > > ``` > > below. > > Benjamin Bannier wrote: > Could you explain the pattern we follow? I mostly went for a > StandaloneMasterDetector instead of an Owned<MasterDetector> because of the > conceptually simpler type (value vs pointer), but we seem to use both here. > > Chun-Hung Hsiao wrote: > I'm in favor of abstract types (e.g., `MasterDetector`) over concrete > subtypes (e.g., `StandaloneMasterDetector`). Please feel free to drop this if > you prefer avoiding the pointer type :)
Dropping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review211997 ----------------------------------------------------------- On Jan. 16, 2019, 11:51 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2019, 11:51 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441debbbbb > src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2 > src/slave/http.hpp 5b113fa2f7e3421d4219e0ece113010937b204c1 > src/slave/http.cpp e0dc09103e9186aa3f7328d2052fc6747f5be9bb > src/slave/slave.hpp 2eadf5fce9a314f1ec0ac5d51820c6381f5f1468 > src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6 > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6 > > > Diff: https://reviews.apache.org/r/68147/diff/14/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
