> On Jan. 17, 2019, 5:42 a.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 3355 (patched) > > <https://reviews.apache.org/r/68147/diff/14/?file=2119929#file2119929line3355> > > > > Most handlers print this line *before* creating the approvers. Let's > > move this before L3345. > > > > (Not yours, but the logging of `addResourceProviderConfig`, > > `updateResourceProviderConfig` and `removeResourceProviderConfig` should be > > adjusted instead. We can address the consistency issue with a followup > > patch.)
Fixed and created https://reviews.apache.org/r/69782/. > On Jan. 17, 2019, 5:42 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8020 (patched) > > <https://reviews.apache.org/r/68147/diff/14/?file=2119931#file2119931line8020> > > > > How about adding the following check? > > ``` > > CHECK(!protobuf::isTerminalState(operation->latest_status().state())); > > ``` Good point, we actually only want to work on non-terminal operations here. Adding a hard `CHECK` here couples us strongly to what operations the agent stores, something I'd like to avoid -- if only because it increases the amount of invariants one needs to keep in mind. How about just skipping non-terminal operations here instead? I updated the patch for that. Dropping for now, please reopen if you feel this needs further discussion. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review212103 ----------------------------------------------------------- On Jan. 17, 2019, 12:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2019, 12:17 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441debbbbb > src/master/master.cpp 7c8d3ce3271fd1d6b8e6e85e996f96572a7d48a6 > src/slave/http.hpp 5b113fa2f7e3421d4219e0ece113010937b204c1 > src/slave/http.cpp e0dc09103e9186aa3f7328d2052fc6747f5be9bb > src/slave/slave.hpp 2eadf5fce9a314f1ec0ac5d51820c6381f5f1468 > src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6 > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp 76ec56b530ed259b8e2cb7794074b6b72cec86b3 > > > Diff: https://reviews.apache.org/r/68147/diff/15/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
