----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review212103 -----------------------------------------------------------
Fix it, then Ship it! src/slave/http.cpp Lines 3355 (patched) <https://reviews.apache.org/r/68147/#comment297703> Most handlers print this line *before* creating the approvers. Let's move this before L3345. (Not yours, but the logging of `addResourceProviderConfig`, `updateResourceProviderConfig` and `removeResourceProviderConfig` should be adjusted instead. We can address the consistency issue with a followup patch.) src/slave/slave.cpp Lines 8020 (patched) <https://reviews.apache.org/r/68147/#comment297705> How about adding the following check? ``` CHECK(!protobuf::isTerminalState(operation->latest_status().state())); ``` src/slave/slave.cpp Lines 8020 (patched) <https://reviews.apache.org/r/68147/#comment297706> src/slave/slave.cpp Lines 8020 (patched) <https://reviews.apache.org/r/68147/#comment297707> src/slave/slave.cpp Lines 8020 (patched) <https://reviews.apache.org/r/68147/#comment297708> src/slave/slave.cpp Lines 8034-8038 (patched) <https://reviews.apache.org/r/68147/#comment297704> ``` protobuf::createOperationStatus( OPERATION_GONE_BY_OPERATOR, operationId, "The resource provider ... received", None(), None(), info.id()); ``` The we can get rid of L8051-8053. - Chun-Hung Hsiao On Jan. 16, 2019, 10:51 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2019, 10:51 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441debbbbb > src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2 > src/slave/http.hpp 5b113fa2f7e3421d4219e0ece113010937b204c1 > src/slave/http.cpp e0dc09103e9186aa3f7328d2052fc6747f5be9bb > src/slave/slave.hpp 2eadf5fce9a314f1ec0ac5d51820c6381f5f1468 > src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6 > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6 > > > Diff: https://reviews.apache.org/r/68147/diff/14/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
