> On Jan. 18, 2019, 4:42 a.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3330 (patched) > > <https://reviews.apache.org/r/69781/diff/1/?file=2120161#file2120161line3334> > > > > Is this really required?
This one conservative approach to deal with the possibility of them being different. Alternatively one could instead advance only by their maximum value. If at all we currently advance by both durations. Dropping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69781/#review212125 ----------------------------------------------------------- On Jan. 18, 2019, 12:45 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69781/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2019, 12:45 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9130 > https://issues.apache.org/jira/browse/MESOS-9130 > > > Repository: mesos > > > Description > ------- > > While we addressed one source of flakiness of this test in > `2117f671c450d7c74edc53078e8c0ed6035020aa` we introduced a new source of > flakiness (agents send more than the expected number of > `UpdateSlaveMessage`s since they failed a timeout in registration with > the master). > > This patch ensures that the agent registers successfully before > continuing with the test. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 164e93a3749d4d668e12de31641aecddddece384 > > > Diff: https://reviews.apache.org/r/69781/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
