----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69781/#review212275 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Lines 3388 (patched) <https://reviews.apache.org/r/69781/#comment298013> IIUC the async loop you mentioned is the one trying to detect the creation of the domain socket, which is asynchronously called in `launchContainer`, so waiting for just this function to be dispatched might not be sufficient before pausing the clock again. How about waiting for `waitContainer` (to ensure that the post-start hook and thus the async loop has been finished) after `launchContainer` and before the pause? Alternatively, since this test doesn't actually care what happens after `launchContainer`, is it needed to resume the clock at all? - Chun-Hung Hsiao On Jan. 18, 2019, 11:45 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69781/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2019, 11:45 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9130 > https://issues.apache.org/jira/browse/MESOS-9130 > > > Repository: mesos > > > Description > ------- > > While we addressed one source of flakiness of this test in > `2117f671c450d7c74edc53078e8c0ed6035020aa` we introduced a new source of > flakiness (agents send more than the expected number of > `UpdateSlaveMessage`s since they failed a timeout in registration with > the master). > > This patch ensures that the agent registers successfully before > continuing with the test. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 164e93a3749d4d668e12de31641aecddddece384 > > > Diff: https://reviews.apache.org/r/69781/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
