> On Jan. 18, 2019, 6:59 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > > Line 43 (original), 43 (patched) > > <https://reviews.apache.org/r/69082/diff/3/?file=2119976#file2119976line43> > > > > s/path/template/ and s/string/path/ would be clearer?
I believe this would warrant another path as such a change would have no relation to what is done here. Unfortunately `template` is a (not context sensitive) keyword, so I am not sure what exactly would help making this much clearer. I can post a patch if you could suggest something. Dropping for now. > On Jan. 18, 2019, 6:59 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Line 143 (original), 140-146 (patched) > > <https://reviews.apache.org/r/69082/diff/3/?file=2119977#file2119977line143> > > > > ditto here See above. > On Jan. 18, 2019, 6:59 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 164 (patched) > > <https://reviews.apache.org/r/69082/diff/3/?file=2119978#file2119978line167> > > > > Does `stringify(*fd)` make it fit on one line? Yes, it would, but AFAIK we don't have that operator defined for `Try`. I created https://issues.apache.org/jira/browse/MESOS-7124 for this some time ago and also gave some argument why I think this would have better semantics than current use of `get`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212146 ----------------------------------------------------------- On Jan. 24, 2019, 11:30 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69082/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 11:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Alex Clemmer. > > > Bugs: MESOS-9331 > https://issues.apache.org/jira/browse/MESOS-9331 > > > Repository: mesos > > > Description > ------- > > When e.g., writing to disk, errors from write might only manifest at > ::close time. We update some instances to correctly propagate these > errors instead of dropping them silently. We only propagate the > ::close error if the write operation succeeded, otherwise we just > propagate the error from the write operation. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > 63b3d1a7720d07f877fa1d4eb7f32a548916637a > 3rdparty/stout/include/stout/os/write.hpp > f7538f94f5a953a7a90a05bc1d2f138b6c17f814 > 3rdparty/stout/include/stout/protobuf.hpp > eb4adef56f1701e3c101284e05e4e6c66eef9180 > > > Diff: https://reviews.apache.org/r/69082/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
