----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212309 -----------------------------------------------------------
Fix it, then Ship it! Thanks for putting this up and also thank BenM for a thorough review! 3rdparty/stout/include/stout/os/posix/mktemp.hpp Line 39 (original), 39 (patched) <https://reviews.apache.org/r/69082/#comment298061> I agree with BenM. `string` seems not very readable and shadows `std::string`, which I don't like. How about: ``` s/temp/_path/ s/string/temp/ ``` - Chun-Hung Hsiao On Jan. 24, 2019, 10:30 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69082/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 10:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Alex Clemmer. > > > Bugs: MESOS-9331 > https://issues.apache.org/jira/browse/MESOS-9331 > > > Repository: mesos > > > Description > ------- > > When e.g., writing to disk, errors from write might only manifest at > ::close time. We update some instances to correctly propagate these > errors instead of dropping them silently. We only propagate the > ::close error if the write operation succeeded, otherwise we just > propagate the error from the write operation. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > 63b3d1a7720d07f877fa1d4eb7f32a548916637a > 3rdparty/stout/include/stout/os/write.hpp > f7538f94f5a953a7a90a05bc1d2f138b6c17f814 > 3rdparty/stout/include/stout/protobuf.hpp > eb4adef56f1701e3c101284e05e4e6c66eef9180 > > > Diff: https://reviews.apache.org/r/69082/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
