-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69082/
-----------------------------------------------------------
(Updated Jan. 28, 2019, 11:39 a.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Alex Clemmer.
Changes
-------
Addressed issue raised by Chun.
Bugs: MESOS-9331
https://issues.apache.org/jira/browse/MESOS-9331
Repository: mesos
Description
-------
When e.g., writing to disk, errors from write might only manifest at
::close time. We update some instances to correctly propagate these
errors instead of dropping them silently. We only propagate the
::close error if the write operation succeeded, otherwise we just
propagate the error from the write operation.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/mktemp.hpp
63b3d1a7720d07f877fa1d4eb7f32a548916637a
3rdparty/stout/include/stout/os/write.hpp
f7538f94f5a953a7a90a05bc1d2f138b6c17f814
3rdparty/stout/include/stout/protobuf.hpp
eb4adef56f1701e3c101284e05e4e6c66eef9180
Diff: https://reviews.apache.org/r/69082/diff/5/
Changes: https://reviews.apache.org/r/69082/diff/4-5/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
