----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213205 -----------------------------------------------------------
Note on commit message: s/<slave_id/<slave_id>/ src/slave/paths.hpp Lines 365 (patched) <https://reviews.apache.org/r/70044/#comment299075> Could you add a header comment for this? I know it'll be pretty simple, but I hate to see new functions added to headers with no comments. I think brief explanations of what the functions do would be beneficial. Here and below. src/slave/slave.cpp Lines 7452 (patched) <https://reviews.apache.org/r/70044/#comment299134> What's the reason for moving this? - Greg Mann On Feb. 23, 2019, 1:34 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70044/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2019, 1:34 a.m.) > > > Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-9597 > https://issues.apache.org/jira/browse/MESOS-9597 > > > Repository: mesos > > > Description > ------- > > This patch moves the operation status update streams for operations > affecting agent default resources from the root of the metadata > directory to the agent's metadata directory, i.e., > `meta/operations/<operation_uuid>` to > `meta/slaves/<slave_id/operations/<operation_uuid>`. > > > Diffs > ----- > > src/slave/paths.hpp bddaef220b4c9ac7d7988664cd82828e32f5a0df > src/slave/paths.cpp 4ff9c5da05aef1496323daf269ab9b3215b0b31f > src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 > src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 > > > Diff: https://reviews.apache.org/r/70044/diff/1/ > > > Testing > ------- > > Tests still pass on GNU/Linux + quite some manual testing. > > > Thanks, > > Gastón Kleiman > >
