kaysoky commented on a change in pull request #326: MESOS-6874: Validate the
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264383368
##########
File path: src/slave/containerizer/composing.cpp
##########
@@ -425,6 +425,28 @@ Future<Containerizer::LaunchResult>
ComposingContainerizerProcess::_launch(
}
+static Try<Nothing> validateContainerInfoType(const ContainerInfo& info)
+{
+ const auto* typeDescriptor = ContainerInfo::Type_descriptor();
+ const auto* infoDescriptor = ContainerInfo::descriptor();
+ for (int index = 0; index < typeDescriptor->value_count(); index++) {
+ const auto* typeValueDescriptor = typeDescriptor->value(index);
+ const auto* infoValueDescriptor = infoDescriptor->FindFieldByName(
+ strings::lower(typeValueDescriptor->name()));
+ CHECK_NOTNULL(infoValueDescriptor);
+
+ if (
+ int(info.type()) != typeValueDescriptor->number() &&
Review comment:
It looks like, in every protobuf union except this one, we have an `UNKNOWN
= 0` Type, which guards against future additions to the protobuf. If you end
up generalizing this helper, the `0` case will need to be ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
