kaysoky commented on a change in pull request #326: MESOS-6874: Validate the
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264819458
##########
File path: src/tests/containerizer/composing_containerizer_tests.cpp
##########
@@ -57,6 +57,32 @@ namespace tests {
class ComposingContainerizerTest : public MesosTest {};
+TEST_F(ComposingContainerizerTest, FailsOnContainerInfoTypeMismatch)
Review comment:
I'm referring to the how the containerizers are passed messages. When the
`--containerizers` flag only has a single entry (`mesos` or `docker`), the
`ComposingContainerizer` is not used. That means the validation logic added
here will not be run, even though the validation logic is still useful in these
cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
