kaysoky commented on a change in pull request #326: MESOS-6874: Validate the
match between Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r264386370
##########
File path: include/mesos/mesos.proto
##########
@@ -3328,6 +3328,9 @@ message TTYInfo {
*/
message ContainerInfo {
// All container implementation types.
+ // For each type there should be a field in the ContainerInfo itself
+ // with exactly matching name in the lowercase.
Review comment:
I just realized that the protobuf docs removed mention of their union trick
a few months ago 😱
https://github.com/protocolbuffers/protobuf/issues/452
Here is a snapshot of the union trick documentation:
https://web.archive.org/web/20170715111519/https://developers.google.com/protocol-buffers/docs/techniques
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
