----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70371/#review214296 -----------------------------------------------------------
Ship it! Thanks for the test! In the description, "is counted towards its parent's consumed quota"? src/tests/hierarchical_allocator_tests.cpp Lines 6125 (patched) <https://reviews.apache.org/r/70371/#comment300510> what does "set" mean here? this test "uses"? src/tests/hierarchical_allocator_tests.cpp Lines 6127-6132 (patched) <https://reviews.apache.org/r/70371/#comment300511> Makes sense, thanks for the explanation! - Benjamin Mahler On April 2, 2019, 10:29 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70371/ > ----------------------------------------------------------- > > (Updated April 2, 2019, 10:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9688 > https://issues.apache.org/jira/browse/MESOS-9688 > > > Repository: mesos > > > Description > ------- > > This test verifies that a subrole's reservation is counted towards > its parent's reservation when accounting consumed quota. > See MESOS-9688. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 39e209b4162fa743540e194912f546e9496b20b8 > > > Diff: https://reviews.apache.org/r/70371/diff/1/ > > > Testing > ------- > > make check > The test does not pass without r/70353. > > > Thanks, > > Meng Zhu > >
