-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70303/
-----------------------------------------------------------
(Updated April 3, 2019, 12:50 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments from r/70361.
Bugs: MESOS-9624
https://issues.apache.org/jira/browse/MESOS-9624
Repository: mesos
Description
-------
The equality check and output helpers for CSI v0 protobufs are now
declared in the `v0.hpp` header to ensure ADL works properly. The
implementation is also moved to a new `v0.cpp` file.
The header and implementation files for CSI v0 utility helpers are also
renamed for future CSI v1 support.
Diffs (updated)
-----
include/mesos/csi/v0.hpp 19d9445fe1da7be6e41b484b5a78dcd10e5ece52
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3
src/csi/service_manager.cpp PRE-CREATION
src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf
src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
src/csi/v0.cpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/examples/test_csi_plugin.cpp 73a6c43e72afec0dd124b0fe2f8ef0e45acb307f
src/resource_provider/storage/uri_disk_profile_adaptor.cpp
cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/csi_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70303/diff/4/
Changes: https://reviews.apache.org/r/70303/diff/3-4/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
