-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70430/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9452
https://issues.apache.org/jira/browse/MESOS-9452
Repository: mesos
Description
-------
This patch keeps the sorting related information in the memory
and accompanies a dirty bit with it. This helps to avoid
unnecessary recalculation of this info in `sort()`.
Diffs
-----
src/master/allocator/sorter/random/sorter.hpp
125ce84761e4c930370912151700ddda35d7b6c1
src/master/allocator/sorter/random/sorter.cpp
bbe130dbf3b158ea14f9572bc5d14200fcd85127
Diff: https://reviews.apache.org/r/70430/diff/1/
Testing
-------
make check
Benchmarking:
Optimized build with
QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
tl;dr: Performance is now on par with before the change in r/70429
## Before r/70429:
Added 3000 agents in 85.844373ms
Added 3000 frameworks in 19.713969615secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
Made 3500 allocations in 13.690538305secs
Made 0 allocation in 9.76855825secs
## After r/70429 and this:
Added 3000 agents in 105.284907ms
Added 3000 frameworks in 19.253697264secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
Made 3500 allocations in 13.488219803secs
Made 0 allocation in 9.846584089secs
Thanks,
Meng Zhu
