----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70430/#review214730 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70429', '70430']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3194/mesos-review-70430 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3194/mesos-review-70430/logs/mesos-tests.log): ``` I0417 20:04:41.052911 60364 master.cpp:3352] Deactivating agent efd9479a-837b-4a3a-a36c-857f3c996ef4-S0 at slave(501)@192.10.1.4:49808 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0417 20:04:41.052911 66860 hierarchical.cpp:392] Removed framework efd9479a-837b-4a3a-a36c-857f3c996ef4-0000 I0417 20:04:41.053927 66860 hierarchical.cpp:829] Agent efd9479a-837b-4a3a-a36c-857f3c996ef4-S0 deactivated I0417 20:04:41.054914 64488 containerizer.cpp:2576] Destroying container 263075ab-fc67-48ed-bb65-9eef9d6dddd6 in RUNNING state I0417 20:04:41.054914 64488 containerizer.cpp:3278] Transitioning the state of container 263075ab-fc67-48ed-bb65-9eef9d6dddd6 from RUNNING to DESTROYING I0417 20:04:41.054914 64488 launcher.cpp:161] Asked to destroy container 263075ab-fc67-48ed-bb65-9eef9d6dddd6 W0417 20:04:41.055905 67104 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=3260 to peer '192.10.1.4:52213': IO failed with error code: The specified network name is no longer avail[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (773 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (794 ms total) [----------] Global test environment tear-down [==========] 1161 tests from 109 test cases ran. (576626 ms total) [ PASSED ] 1157 tests. [ FAILED ] 4 tests, listed below: [ FAILED ] RandomSorterTest.HierarchicalProbabilityDistribution [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 4 FAILED TESTS YOU HAVE 233 DISABLED TESTS able. W0417 20:04:41.056910 67104 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=4536 to peer '192.10.1.4:52214': IO failed with error code: The specified network name is no longer available. I0417 20:04:41.121827 60872 containerizer.cpp:3117] Container 263075ab-fc67-48ed-bb65-9eef9d6dddd6 has exited I0417 20:04:41.150856 62096 master.cpp:1135] Master terminating I0417 20:04:41.152860 65164 hierarchical.cpp:680] Removed agent efd9479a-837b-4a3a-a36c-857f3c996ef4-S0 I0417 20:04:42.002846 67104 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 9, 2019, 12:01 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70430/ > ----------------------------------------------------------- > > (Updated April 9, 2019, 12:01 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9733 > https://issues.apache.org/jira/browse/MESOS-9733 > > > Repository: mesos > > > Description > ------- > > This patch keeps the sorting related information in the memory > and accompanies a dirty bit with it. This helps to avoid > unnecessary recalculation of this info in `sort()`. > > > Diffs > ----- > > src/master/allocator/sorter/random/sorter.hpp > 125ce84761e4c930370912151700ddda35d7b6c1 > src/master/allocator/sorter/random/sorter.cpp > bbe130dbf3b158ea14f9572bc5d14200fcd85127 > > > Diff: https://reviews.apache.org/r/70430/diff/2/ > > > Testing > ------- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > > tl;dr: Performance is now on par with before the change in r/70429 > > ## Before r/70429: > Added 3000 agents in 85.844373ms > Added 3000 frameworks in 19.713969615secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3500 allocations in 13.690538305secs > Made 0 allocation in 9.76855825secs > > ## After r/70429 and this: > Added 3000 agents in 105.284907ms > Added 3000 frameworks in 19.253697264secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3500 allocations in 13.488219803secs > Made 0 allocation in 9.846584089secs > > > Thanks, > > Meng Zhu > >
