----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70430/#review214867 -----------------------------------------------------------
Bad review! Reviews applied: [70430, 70429, 70542] Error: 2019-04-24 22:44:57 URL:https://reviews.apache.org/r/70430/diff/raw/ [3397/3397] -> "70430.patch" [1] error: patch failed: src/master/allocator/sorter/random/sorter.cpp:68 error: src/master/allocator/sorter/random/sorter.cpp: patch does not apply - Mesos Reviewbot On April 8, 2019, 5:01 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70430/ > ----------------------------------------------------------- > > (Updated April 8, 2019, 5:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9733 > https://issues.apache.org/jira/browse/MESOS-9733 > > > Repository: mesos > > > Description > ------- > > This patch keeps the sorting related information in the memory > and accompanies a dirty bit with it. This helps to avoid > unnecessary recalculation of this info in `sort()`. > > > Diffs > ----- > > src/master/allocator/sorter/random/sorter.hpp > 125ce84761e4c930370912151700ddda35d7b6c1 > src/master/allocator/sorter/random/sorter.cpp > bbe130dbf3b158ea14f9572bc5d14200fcd85127 > > > Diff: https://reviews.apache.org/r/70430/diff/3/ > > > Testing > ------- > > make check > > Benchmarking: > Optimized build with > QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > > tl;dr: Performance is now on par with before the change in r/70429 > > ## Before r/70429: > Added 3000 agents in 85.844373ms > Added 3000 frameworks in 19.713969615secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3500 allocations in 13.690538305secs > Made 0 allocation in 9.76855825secs > > ## After r/70429 and this: > Added 3000 agents in 105.284907ms > Added 3000 frameworks in 19.253697264secs > Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks > Made 3500 allocations in 13.488219803secs > Made 0 allocation in 9.846584089secs > > > Thanks, > > Meng Zhu > >
