----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215071 -----------------------------------------------------------
Hm.. don't we need to track the amount held back during the quota allocation? What are your thoughts on that? src/master/allocator/mesos/hierarchical.cpp Lines 1800 (patched) <https://reviews.apache.org/r/70570/#comment301463> "and available" or " ; available" src/master/allocator/mesos/hierarchical.cpp Lines 1930-1942 (original), 1934-1946 (patched) <https://reviews.apache.org/r/70570/#comment301464> Isn't this also holding back for headroom? src/master/allocator/mesos/hierarchical.cpp Lines 2012-2019 (patched) <https://reviews.apache.org/r/70570/#comment301466> Probably clearer with a single comment above the two variables about what we track for logging purposes? src/master/allocator/mesos/hierarchical.cpp Lines 2018 (patched) <https://reviews.apache.org/r/70570/#comment301465> s/these/this/ ? src/master/allocator/mesos/hierarchical.cpp Lines 2019 (patched) <https://reviews.apache.org/r/70570/#comment301468> size_t? src/master/allocator/mesos/hierarchical.cpp Lines 2090 (patched) <https://reviews.apache.org/r/70570/#comment301467> pre-increment? src/master/allocator/mesos/hierarchical.cpp Lines 2122 (patched) <https://reviews.apache.org/r/70570/#comment301469> were held back src/master/allocator/mesos/hierarchical.cpp Lines 2123 (patched) <https://reviews.apache.org/r/70570/#comment301470> "for that" -> "to ensure sufficient headroom" src/master/allocator/mesos/hierarchical.cpp Lines 2124 (patched) <https://reviews.apache.org/r/70570/#comment301471> "were filtered" - Benjamin Mahler On April 30, 2019, 1 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70570/ > ----------------------------------------------------------- > > (Updated April 30, 2019, 1 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9759 > https://issues.apache.org/jira/browse/MESOS-9759 > > > Repository: mesos > > > Description > ------- > > Logged headroom related info in the allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70570/diff/3/ > > > Testing > ------- > > N/A > > > Thanks, > > Meng Zhu > >
