> On May 6, 2019, 1:50 p.m., Benjamin Mahler wrote: > > Hm.. don't we need to track the amount held back during the quota > > allocation? What are your thoughts on that?
We hold back something in the quota allocation loop, then in the second stage, we try to allocate everything (including the “held back” in the 1st stage). > On May 6, 2019, 1:50 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1930-1942 (original), 1934-1946 (patched) > > <https://reviews.apache.org/r/70570/diff/3/?file=2142150#file2142150line1934> > > > > Isn't this also holding back for headroom? We hold back something in the quota allocation loop, then in the second stage, we try to allocate everything (including the “held back” in the 1st stage). - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215071 ----------------------------------------------------------- On May 8, 2019, 5:22 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70570/ > ----------------------------------------------------------- > > (Updated May 8, 2019, 5:22 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9759 > https://issues.apache.org/jira/browse/MESOS-9759 > > > Repository: mesos > > > Description > ------- > > This patch logs `requiredHeadroom` and `availableHeadroom` > before each allocation cycle and logs `requiredHeadroom`, > resources and number of agents held back for quota `headroom` > as well as resources filtered at the end of each allocation > cycle. > > While we also held resources back for quota headroom in the > first stage, we do not log it there. This is because in the > second stage, we try to allocate all resources (including the > ones held back in the first stage). Thus only resources held > back in the second stage are truly held back for the whole > allocation cycle. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70570/diff/5/ > > > Testing > ------- > > N/A > > > Thanks, > > Meng Zhu > >
