----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215081 -----------------------------------------------------------
Patch looks great! Reviews applied: [70570] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 30, 2019, 1 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70570/ > ----------------------------------------------------------- > > (Updated April 30, 2019, 1 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9759 > https://issues.apache.org/jira/browse/MESOS-9759 > > > Repository: mesos > > > Description > ------- > > This patch logs `requiredHeadroom` and `availableHeadroom` > before each allocation cycle and logs `requiredHeadroom`, > resources and number of agents held back for quota `headroom` > as well as resources filtered at the end of each allocation > cycle. > > While we also held resources back for quota headroom in the > first stage, we do not log it there. This is because in the > second stage, we try to allocate all resources (including the > ones held back in the first stage). Thus only resources held > back in the second stage are truly held back for the whole > allocation cycle. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 64a076ddd29711437d539a06bb0470755828cc87 > > > Diff: https://reviews.apache.org/r/70570/diff/4/ > > > Testing > ------- > > N/A > > > Thanks, > > Meng Zhu > >
