----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71388/#review217484 -----------------------------------------------------------
Fix it, then Ship it! Sorry for the delay! Just catching up after vacation 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp Line 31 (original), 32 (patched) <https://reviews.apache.org/r/71388/#comment305330> it's ok to dlclose with nullptr if close was already called or open was never called or open failed? 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp Line 46 (original), 36 (patched) <https://reviews.apache.org/r/71388/#comment305331> Hm.. this pattern suggests a `Try<DynamicLibrary> create(path)` pattern to avoid the not-yet-opened or failed open states? I guess we may still want the explicit close though for error reporting.. 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp Lines 66 (patched) <https://reviews.apache.org/r/71388/#comment305332> hm.. why is this needed? seems a little non obvious to me - Benjamin Mahler On Aug. 28, 2019, 11:32 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71388/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2019, 11:32 a.m.) > > > Review request for mesos, Benjamin Mahler and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This not only simplifies our implementation of `DynamicLibrary`, but > also removes the potential for accidental file descriptor leaks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp > 6a50592632246b06152bee177e933f65438c07ca > > > Diff: https://reviews.apache.org/r/71388/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
