----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71388/#review217948 -----------------------------------------------------------
Patch looks great! Reviews applied: [71388] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 25, 2019, 9:23 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71388/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2019, 9:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This not only simplifies our implementation of `DynamicLibrary`, but > also removes the potential for accidental file descriptor leaks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp > 6a50592632246b06152bee177e933f65438c07ca > > > Diff: https://reviews.apache.org/r/71388/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
