----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71388/#review217951 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp Lines 70-74 (original), 68-72 (patched) <https://reviews.apache.org/r/71388/#comment305344> hm.. should maybe release / reset to nullptr if dlclose fails as well? E.g. if some other part of the program closes it (bug), I guess whether we reset here will just mean whether we issue an additional bad close call in the destructor. Didn't mark as an issue since the error case here already means something is badly broken. - Benjamin Mahler On Sept. 25, 2019, 9:23 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71388/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2019, 9:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This not only simplifies our implementation of `DynamicLibrary`, but > also removes the potential for accidental file descriptor leaks. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/dynamiclibrary.hpp > 6a50592632246b06152bee177e933f65438c07ca > > > Diff: https://reviews.apache.org/r/71388/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
