----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75006/#review226492 -----------------------------------------------------------
something looks off here with the parsing logic in two places? src/slave/device_manager/device_manager.hpp Lines 75-76 (patched) <https://reviews.apache.org/r/75006/#comment314686> any reason you're taking a copy of these? src/slave/device_manager/state.proto Lines 21 (patched) <https://reviews.apache.org/r/75006/#comment314683> s/Message// src/slave/device_manager/state.proto Lines 22-23 (patched) <https://reviews.apache.org/r/75006/#comment314684> s/`_list`// what are these strings? not clear here.. do we not want a more structured message for a device Entry? src/slave/device_manager/state.proto Lines 26-27 (patched) <https://reviews.apache.org/r/75006/#comment314685> s/Map// s/`_map`// maybe CgroupsDeviceAccess and device_access_per_cgroup? That way you have CgroupDeviceAccess (singular) and CgroupsDeviceAccess (plural) - Benjamin Mahler On May 22, 2024, 8:26 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75006/ > ----------------------------------------------------------- > > (Updated May 22, 2024, 8:26 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This change introduces the DeviceManagerProcess to help > facilitate device access management in cgroups2 via > ebpf program file changes. > > The manager keeps a global state that is checkpointed on change. > Device requests can be made to the manager by calling > DeviceManagerProcess::deny or DeviceManagerProcess::allow. > This manager will be made available to all controllers under the > cgroups2 isolator, and the GPU isolator. > > > Diffs > ----- > > src/CMakeLists.txt 49f6208518e689d593274bb503750d5cc9816255 > src/Makefile.am 68a93674f867ca092ee035ea367f35f4580b073f > src/slave/device_manager/device_manager.hpp PRE-CREATION > src/slave/device_manager/device_manager.cpp PRE-CREATION > src/slave/device_manager/state.hpp PRE-CREATION > src/slave/device_manager/state.proto PRE-CREATION > src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f > src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c > > > Diff: https://reviews.apache.org/r/75006/diff/4/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
