-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75006/
-----------------------------------------------------------

(Updated July 19, 2024, 10:23 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Pulled out changes related to deconfiguring cgroups device accesses and state 
recovery. renamed get_diff_state to apply_diff and made it a static function 
inside DeviceManager only


Repository: mesos


Description (updated)
-------

This change introduces the DeviceManagerProcess to help facilitate
device access management in cgroups2 via ebpf program file changes.

Device requests can be made to the manager by calling
`configure` or `reconfigure`. Note that `configure`
should only be used when setting up a cgroup's device access, i.e. it
has not requested any device to be allowed/denied before.
In addition, `reconfigure` cannot be used to add deny entries containing
wildcards.
This manager will be made available to all controllers under the
cgroups2 isolator, and the GPU isolator.


Diffs (updated)
-----

  src/CMakeLists.txt ea0fee1bbaed6f2494e9b9739bb65812a4a0042b 
  src/Makefile.am 03eb0cc28ee18da7f1a13f35a7e3255e56869b56 
  src/slave/containerizer/device_manager/device_manager.hpp PRE-CREATION 
  src/slave/containerizer/device_manager/device_manager.cpp PRE-CREATION 
  src/tests/containerizer/cgroups2_tests.cpp 
3982e25987c40bc3748bc9be4e7b19c5b53dc211 
  src/tests/device_manager_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/75006/diff/18/

Changes: https://reviews.apache.org/r/75006/diff/17-18/


Testing
-------

Added unit tests for DeviceManager to test setup_configure and 
incremental_configure, added test for recover.
All unit tests pass


Thanks,

Jason Zhou

Reply via email to