-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75006/
-----------------------------------------------------------

(Updated July 17, 2024, 7:06 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Removed DeviceManagerProcess from device_manager.hpp per convention


Repository: mesos


Description
-------

This change introduces the DeviceManagerProcess to help facilitate
device access management in cgroups2 via ebpf program file changes.

The manager keeps a global state that is checkpointed on change.
Device requests can be made to the manager by calling
incremental_configure or setup_configure. Note that setup_configure
should only be used when setting up a cgroup's device access, i.e. it
has not requested any device to be allowed/denied before.
In addition, setup_configure cannot be used to add deny wildcards.
This manager will be made available to all controllers under the
cgroups2 isolator, and the GPU isolator.


Diffs (updated)
-----

  src/CMakeLists.txt ea0fee1bbaed6f2494e9b9739bb65812a4a0042b 
  src/Makefile.am 03eb0cc28ee18da7f1a13f35a7e3255e56869b56 
  src/linux/cgroups2.hpp accaebdaddc85acdd96b87161ea441c77b025099 
  src/linux/cgroups2.cpp cb3c425a46f33f5434f870c03dd7de5be3331ece 
  src/slave/device_manager/device_manager.hpp PRE-CREATION 
  src/slave/device_manager/device_manager.cpp PRE-CREATION 
  src/slave/device_manager/state.hpp PRE-CREATION 
  src/slave/device_manager/state.proto PRE-CREATION 
  src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
  src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 
  src/tests/device_manager_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/75006/diff/17/

Changes: https://reviews.apache.org/r/75006/diff/16-17/


Testing
-------

Added unit tests for DeviceManager to test setup_configure and 
incremental_configure, added test for recover.
All unit tests pass


Thanks,

Jason Zhou

Reply via email to