Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/144#discussion_r10643105
--- Diff: core/src/main/scala/org/apache/spark/util/StatCounter.scala ---
@@ -29,6 +29,8 @@ class StatCounter(values: TraversableOnce[Double])
extends Serializable {
private var n: Long = 0 // Running count of our values
private var mu: Double = 0 // Running mean of our values
private var m2: Double = 0 // Running variance numerator (sum of (x -
mean)^2)
+ private var max_v: Double = Double.NegativeInfinity // Running max of
our values
+ private var min_v: Double = Double.PositiveInfinity // Running min of
our values
--- End diff --
Small style nit, both here and in Python -- we don't use underscores in
variable names usually, so call these `maxValue` and `minValue`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
