Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/144#discussion_r10643101
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
---
@@ -478,6 +478,28 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]]
extends Serializable {
}
/**
+ * Returns the maximum element from this RDD as defined by the specified
+ * Comparator[T].
+ * @params comp the comparator that defines ordering
+ * @return the maximum of the RDD
+ * */
+ def max(comp: Comparator[T]): T = {
+ import scala.collection.JavaConversions._
--- End diff --
I don't think you need to import this if you're going to call
Ordering.comparatorToOrdering directly -- was it necessary? It was in some
other methods because they used other conversions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
