Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/172#discussion_r10718473 --- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala --- @@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable { newBS } + + /** + * Compute the symmetric difference by performing bit-wise XOR of the two sets returning the + * result. + */ + def ^(other: BitSet): BitSet = { + val newBS = new BitSet(math.max(capacity, other.capacity)) + assert(newBS.numWords >= numWords) + assert(newBS.numWords >= other.numWords) + val smaller = math.min(numWords, other.numWords) + var ind = 0 + while( ind < smaller ) { + newBS.words(ind) = words(ind) ^ other.words(ind) + ind += 1 + } + while( ind < numWords ) { --- End diff -- it would be much faster if you replace the following two while loops with an array copy (potentially with unsafe - but that's for another day)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---