Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718568
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newBS
}
+
+ /**
+ * Compute the symmetric difference by performing bit-wise XOR of the
two sets returning the
+ * result.
+ */
+ def ^(other: BitSet): BitSet = {
+ val newBS = new BitSet(math.max(capacity, other.capacity))
+ assert(newBS.numWords >= numWords)
+ assert(newBS.numWords >= other.numWords)
+ val smaller = math.min(numWords, other.numWords)
+ var ind = 0
+ while( ind < smaller ) {
+ newBS.words(ind) = words(ind) ^ other.words(ind)
+ ind += 1
+ }
+ while( ind < numWords ) {
+ newBS.words(ind) = words(ind)
+ ind += 1
+ }
+ while( ind < other.numWords ) {
+ newBS.words(ind) = other.words(ind)
+ ind += 1
+ }
+ newBS
+ }
+
+ /**
+ * Compute the difference of the two sets by performing bit-wise AND-NOT
returning the
+ * result.
+ */
+ def &~(other: BitSet): BitSet = {
--- End diff --
Do you mind renaming this function to andNot? It is not obvious to non
scala programmers that ~ is negation. If you want to maintain the Scala
operator style, you can create a &~ function that delegates to andNot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
