Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/128#issuecomment-38440744
  
    yes I can add something, although I don't really have a way to test it.  
    
    Note that my original question was how we want to go about adding support 
for windows/linux specific shell commands.  Borrowing from Hadoop, we could 
create some generic classes like UnixShellScriptBuilder and 
WindowsShellScriptBuilder then based on the OS type instantiate the correct 
one.    Or since this is only one place I could just conditionalize it there 
and if we add more shell commands it can be made generic later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to