Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/224#discussion_r10928654
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -20,10 +20,114 @@ package catalyst
     package expressions
     
     import org.apache.spark.sql.catalyst.types.BooleanType
    +import java.util.regex.Pattern
     
    -case class Like(left: Expression, right: Expression) extends 
BinaryExpression {
    -  def dataType = BooleanType
    -  def nullable = left.nullable // Right cannot be null.
    +import catalyst.types.StringType
    --- End diff --
    
    As specified in [the Spark Code Style 
Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Imports),
 please use full qualified package imports here, and reorder all the imports 
accordingly. Spark SQL used to use relative package imports, but has already 
been fixed in an earlier PR :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to